Tags: concaf/triggers
Tags
Fix example SA permissions The service account used for examples had permissions for all namespaced Triggers resources but not `clustertriggerbindings`. With the switch to using listers instead of making direct API calls this means that the EL will keep printing out error log messages about not being able to fetch clustertriggerbindings. To fix this, I added updated the SA with the right ClusterRole and Binding. In addition, some of the examples were using their own roles/SAs/bindings. Instead of updating those, I created a single `rbac.yaml` file and added symlinks to it from the examples. Fixes tektoncd#846 Signed-off-by: Dibyo Mukherjee <[email protected]>
Migrate all usages of template.name to template.ref Signed-off-by: Dibyo Mukherjee <[email protected]>
Merge annotations on created resources In tektoncd#712, we added a feature to propagate annotations added to the EL to its underlying resources. However, this resulted in infinite reconcile loops since the deployment controller will add a standard revision annotation that the EL controller will keep trying to overwrite. To fix this, this commit switches the annotation propagation to merge any annotations set on the underlying resources before adding any extra annotations from the EL. Fixes tektoncd#752 Signed-off-by: Dibyo Mukherjee <[email protected]>
PreviousNext