-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dedupe_Levenshtein_search #29039
Conversation
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/dedupe_Levenshtein_search/recipe.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13180368339. Examine the logs at this URL for more detail. |
tests: | ||
- python: | ||
imports: | ||
- dedupe_Levenshtein_search |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This (+ the name of the conda package, aka name
in the context) should probably be Levenshtein_search
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or – according to the linter and sane taste – let's call the conda package dedupe-levenshtein-search
. levenshtein-search
is taken by the original project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import must be Levenshtein_search
though as that's the specified name here:
https://github.com/dedupeio/Levenshtein_search/blob/639fa6d406ec26c55ca8fc5cf15fc0f315bb31ac/setup.py#L11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @moritzwilksch !
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/help-python, ready for review! |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).