Add dp-accounting

[rpreen]

Checklist

• Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
• License file is packaged (see here for an example).
• Source is from official source.
• Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
• If static libraries are linked in, the license of the static library is packaged.
• Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
• Build number is 0.
• A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
• GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
• When in trouble, please check our knowledge base documentation before pinging a team.

[github-actions]

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

[conda-forge-admin]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/dp-accounting/meta.yaml) and found it was in an excellent condition.

[rpreen]

@conda-forge/help-python, ready for review!

[ocefpaf]

Suggested change

	script: {{ PYTHON }} -m pip install . -vv
	script: {{ PYTHON }} -m pip install . -vv --no-deps --no-build-isolation

[ocefpaf]

Should it be 0.4.3?

[ocefpaf]

If you can, please open issues upstream for the missing files and add a comment here so we can track the evolution of these patches.

[ocefpaf]

Not sure that is going on with osx here but we don't need it to merge this PR. The package is noarch.

[rpreen]

OK, thank you!

I have added an issue about the missing files: google/differential-privacy#286

I noticed that the PyPI tar.gz files are named slightly differently in version 0.4.3 and 0.4.4 - where in 0.4.3 (this meta.yaml) the file name is "dp-accounting-0.4.3.tar.gz" but for 0.4.4 it is named "dp_accounting-0.4.4.tar.gz" - does something need to be changed here to deal with both cases because it's using dp-accounting-{{ version }}.tar.gz in the url?

[ocefpaf]

I have added an issue about the missing files: google/differential-privacy#286

👍🏽

I noticed that the PyPI tar.gz files are named slightly differently in version 0.4.3 and 0.4.4 - where in 0.4.3 (this meta.yaml) the file name is "dp-accounting-0.4.3.tar.gz" but for 0.4.4 it is named "dp_accounting-0.4.4.tar.gz" - does something need to be changed here to deal with both cases because it's using dp-accounting-{{ version }}.tar.gz in the url?

The import will work with either _ or -, but you may need to fix the URL. The package name is another problem... PyPI doesn't care and you can pip install it in any form, like the import, but conda does care b/c conda is python agnostic. You can:

1. choose one name and keep it
2. create multiple outputs and claim both names

For 2 see https://github.com/conda-forge/ioos_qc-feedstock/blob/main/recipe/meta.yaml for an example.

[rpreen]

Ok, so the URL will just need to be changed for 0.4.4? I believe it's just an odd naming for 0.4.4 because all the prior versions use the "-" naming as here.

[ocefpaf]

Ok, so the URL will just need to be changed for 0.4.4? I believe it's just an odd naming for 0.4.4 because all the prior versions use the "-" naming as here.

I think PyPI started enforcing _ for URLs. I wish they did the same for naming and installing... But at least we have only 1 URL to download the source now. It is a win.

TL;DR it is not the package/s fault.