Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test_disk_usage for change in default du behaviour in ubuntu 24.04 #1041

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

soapy1
Copy link
Contributor

@soapy1 soapy1 commented Jan 8, 2025

Description

This test started failing due to a difference in how du works on ubuntu 24.04 (the new ubuntu-latest version in GHA) and ubuntu 22.04. See the following example:

(conda-store-server-dev) sophia:conda-store-server/ (test_disk_usage-test✗) $ docker run -i
t ubuntu:24.04
Unable to find image 'ubuntu:24.04' locally
24.04: Pulling from library/ubuntu
de44b265507a: Pull complete 
Digest: sha256:80dd3c3b9c6cecb9f1667e9290b3bc61b78c2678c02cbdae5f0fea92cc6734ab
Status: Downloaded newer image for ubuntu:24.04
root@55628d140146:/# mkdir /test
root@55628d140146:/# du -sb test/
0       test/
root@55628d140146:/# 
exit

(conda-store-server-dev) sophia:conda-store-server/ (test_disk_usage-test✗) $ docker run -it ubuntu:22.04
Unable to find image 'ubuntu:22.04' locally
22.04: Pulling from library/ubuntu
6414378b6477: Pull complete 
Digest: sha256:0e5e4a57c2499249aafc3b40fcd541e9a456aab7296681a3994d631587203f97
Status: Downloaded newer image for ubuntu:22.04
root@65ab5dc1cd16:/# mkdir /test
root@65ab5dc1cd16:/# du -sb test/
4096    test/

This change updates the test to focus on the change in test tmp dir size in order to make the test more applicable across supported OSes.

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for conda-store canceled.

Name Link
🔨 Latest commit da343b4
🔍 Latest deploy log https://app.netlify.com/sites/conda-store/deploys/677ef0b46286fd0008b337d3

Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for conda-store canceled.

Name Link
🔨 Latest commit f99ea30
🔍 Latest deploy log https://app.netlify.com/sites/conda-store/deploys/677f09c4ca730a00088f2cc7

@soapy1 soapy1 force-pushed the test_disk_usage-test branch 5 times, most recently from 9bc9769 to 268c02b Compare January 8, 2025 23:11
@soapy1 soapy1 changed the title Force build Update test_disk_usage for change in default du behaviour in ubuntu 24.04 Jan 8, 2025
@soapy1 soapy1 force-pushed the test_disk_usage-test branch from 268c02b to ab42a24 Compare January 8, 2025 23:24
@soapy1 soapy1 force-pushed the test_disk_usage-test branch from ab42a24 to f99ea30 Compare January 8, 2025 23:26
@soapy1 soapy1 marked this pull request as ready for review January 8, 2025 23:27
@soapy1 soapy1 requested a review from peytondmurray January 8, 2025 23:27
Copy link
Contributor

@peytondmurray peytondmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this improvement, though the test itself isn't very strict. Might be something we can improve in the future.

@peytondmurray peytondmurray merged commit a2778ea into conda-incubator:main Jan 9, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

2 participants