[ANSIENG-4200] | fixing race condition in changing file owner

[rrbadiani]

Description

This task tries to change owner and group of files which exist inside data dir.

All those files are created by kafka user in zookeeper setups.

2 files meta.properties and bootstrap.checkpoint are created by ansible_user which is typically root and different from kafka_broker_user.

Running this task for greenfield fresh setup would change the owner/grp of the above files to kafka_broker_user,kafka_broker_group which is correct behaviour.

But changing the user and owner using this ansible task while cluster upgrades doesnt do anything.

When I tried to change owner and group of data dir and kafka server process in a running cluster using kafka_broker_user & kafka_broker_group it wasnt able to start the cluster and also messed up logs. log files owner didnt change it simply changed the owner of directory which contains log files and thus no new logs were getting written unless manually i change the owner, groups of log files. So it seems even for changing user, group this task isn't helping.

Solution

We can check if kraft/kafka service is running or not.
If running we should skip the task causing race condition and it will have no impact
If not running then we should not skip and run this task. But here it wont be getting trapped in race condition as there wont be any .tmp files coming and going while it runs.

Fixes # (issue)

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

kraft
zk->kr migration

Checklist:

• Any variable/code changes have been validated to be backwards compatible (doesn't break upgrade)
• I have added tests that prove my fix is effective or that my feature works
• If required, I have ensured the changes can be discovered by cp-ansible discovery codebase
• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• Any dependent changes have been merged and published in downstream modules

[mansi-jain-1206]

LGTM, Thanks.

[mansisinha]

LGTM, Also this method of identifying whether the setup is greenfield/brownfield can be used in future as well to extend some of our functionalities. Thanks!