-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7.1 Changelog updated #1949
7.1 Changelog updated #1949
Conversation
508ff0f
to
d8b54b2
Compare
d8b54b2
to
0ed27a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
CHANGELOG.rst
Outdated
@@ -11,7 +11,8 @@ Notable fixes | |||
------------- | |||
|
|||
- Bug fix in Set Permissions on Data Dir files task to avoid race condition | |||
- CP side critical security and vulnerability issues were fixed - https://support.confluent.io/hc/en-us/sections/360008413952-Security-Advisories-and-Security-Release-Notes | |||
- Fixed systemd service override directory permissions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
systemd directory had 640 permission we changed it to 750 i.e gave execcute permissions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then we should add that we gave execute permission in the release notes. The current comment is not conveying what was fixed
8ad6012
to
b5dc6be
Compare
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: