bugfix: connectionproxy prepareStatement not in global transaction (a…

…pache#1805)
conghuhu · Oct 23, 2019 · ab32bee · ab32bee
1 parent 00738ac
commit ab32bee
Showing 1 changed file with 10 additions and 7 deletions.
diff --git a/rm-datasource/src/main/java/io/seata/rm/datasource/AbstractConnectionProxy.java b/rm-datasource/src/main/java/io/seata/rm/datasource/AbstractConnectionProxy.java
@@ -106,13 +106,16 @@ public Statement createStatement() throws SQLException {
     public PreparedStatement prepareStatement(String sql) throws SQLException {
         String dbType = getDbType();
         // support oracle 10.2+
-        PreparedStatement targetPreparedStatement;
-        SQLRecognizer sqlRecognizer = SQLVisitorFactory.get(sql, dbType);
-        if (sqlRecognizer != null && sqlRecognizer.getSQLType() == SQLType.INSERT) {
-            final String tableName = sqlRecognizer.getTableName();
-            TableMeta tableMeta = TableMetaCacheFactory.getTableMetaCache(getDataSourceProxy()).getTableMeta(getDataSourceProxy(), tableName);
-            targetPreparedStatement = getTargetConnection().prepareStatement(sql, new String[]{ tableMeta.getPkName() });
-        } else {
+        PreparedStatement targetPreparedStatement = null;
+        if (RootContext.inGlobalTransaction()) {
+            SQLRecognizer sqlRecognizer = SQLVisitorFactory.get(sql, dbType);
+            if (sqlRecognizer != null && sqlRecognizer.getSQLType() == SQLType.INSERT) {
+                final String tableName = sqlRecognizer.getTableName();
+                TableMeta tableMeta = TableMetaCacheFactory.getTableMetaCache(getDataSourceProxy()).getTableMeta(getDataSourceProxy(), tableName);
+                targetPreparedStatement = getTargetConnection().prepareStatement(sql, new String[]{tableMeta.getPkName()});
+            }
+        }
+        if (targetPreparedStatement == null) {
             targetPreparedStatement = getTargetConnection().prepareStatement(sql);
         }
         return new PreparedStatementProxy(this, targetPreparedStatement, sql);