Skip to content

Commit

Permalink
Pull request conventional commits
Browse files Browse the repository at this point in the history
  • Loading branch information
powerful23 authored Jul 19, 2018
1 parent 4b184c2 commit 37f3c62
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,12 @@ Pull requests should generally be opened against **master**.

Only include ***src*** files in your PR. Don't include any build files i.e. dist/ or lib/. These will be built upon publish to npm and when a release is created on GitHub.

Make sure you have attached a commit message before submitting the PR with the format: ```fix/feat(package_name): message```
For example:
* A change is made in one of the file from @aws-amplify/auth
* When you want to commit the change: git commit -m 'fix(@aws-amplify/auth): the_message'
* Replace fix with feat when this is a feature change

## Tests

Please ensure that your change still passes unit tests, and ideally integration/UI tests. It's OK if you're still working on tests at the time that you submit, but be prepared to be asked about them. Wherever possible, pull requests should contain tests as appropriate. Bugfixes should contain tests that exercise the corrected behavior (i.e., the test should fail without the bugfix and pass with it), and new features should be accompanied by tests exercising the feature.
Expand Down

0 comments on commit 37f3c62

Please sign in to comment.