Skip to content

Commit

Permalink
drm/xe: Migrate OOB WAs to OR rules
Browse files Browse the repository at this point in the history 
Now that rtp has OR rules, it's not needed to extend it to process OOB
WAs. Previously if an entry had no name, it was considered as "a set of
rules OR'ed with the last named entry".

Instead of generating new entries, add OR rules. The syntax for
xe_wa_oob.rules remains the same, with xe_gen_wa_oob generating the
slightly different table. Object sizes delta are negligible, but having
just one logic makes it easier to maintain:

	add/remove: 0/0 grow/shrink: 1/2 up/down: 160/-269 (-109)
	Function                                     old     new   delta
	__compound_literal                          6104    6264    +160
	xe_wa_dump                                  1839    1810     -29
	oob_was                                      816     576    -240
	Total: Before=17257, After=17148, chg -0.63%

Reviewed-by: Gustavo Sousa <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
Signed-off-by: Lucas De Marchi <[email protected]>
  • Loading branch information
@lucasdemarchi
lucasdemarchi committed Jul 29, 2024
1 parent 1c408c5 commit dbcbfc7
Show file tree
Hide file tree
Showing 3 changed files with 37 additions and 49 deletions.
34 changes: 15 additions & 19 deletions drivers/gpu/drm/xe/tests/xe_rtp_test.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -401,16 +401,15 @@ static const struct rtp_test_case rtp_cases[] = {
},
{
.name = "inactive-1st_or_active-inactive",
.expected_active = BIT(1) | BIT(2) | BIT(3),
.expected_active = BIT(1),
.entries = (const struct xe_rtp_entry[]) {
{ XE_RTP_NAME("r1"),
XE_RTP_RULES(FUNC(match_no)),
},
{ XE_RTP_NAME("r2_or_conditions"),
XE_RTP_RULES(FUNC(match_yes)),
},
{ XE_RTP_RULES(FUNC(match_no)) },
{ XE_RTP_RULES(FUNC(match_no)) },
XE_RTP_RULES(FUNC(match_yes), OR,
FUNC(match_no), OR,
FUNC(match_no)) },
{ XE_RTP_NAME("r3"),
XE_RTP_RULES(FUNC(match_no)),
},
Expand All @@ -419,16 +418,15 @@ static const struct rtp_test_case rtp_cases[] = {
},
{
.name = "inactive-2nd_or_active-inactive",
.expected_active = BIT(1) | BIT(2) | BIT(3),
.expected_active = BIT(1),
.entries = (const struct xe_rtp_entry[]) {
{ XE_RTP_NAME("r1"),
XE_RTP_RULES(FUNC(match_no)),
},
{ XE_RTP_NAME("r2_or_conditions"),
XE_RTP_RULES(FUNC(match_no)),
},
{ XE_RTP_RULES(FUNC(match_yes)) },
{ XE_RTP_RULES(FUNC(match_no)) },
XE_RTP_RULES(FUNC(match_no), OR,
FUNC(match_yes), OR,
FUNC(match_no)) },
{ XE_RTP_NAME("r3"),
XE_RTP_RULES(FUNC(match_no)),
},
Expand All @@ -437,16 +435,15 @@ static const struct rtp_test_case rtp_cases[] = {
},
{
.name = "inactive-last_or_active-inactive",
.expected_active = BIT(1) | BIT(2) | BIT(3),
.expected_active = BIT(1),
.entries = (const struct xe_rtp_entry[]) {
{ XE_RTP_NAME("r1"),
XE_RTP_RULES(FUNC(match_no)),
},
{ XE_RTP_NAME("r2_or_conditions"),
XE_RTP_RULES(FUNC(match_no)),
},
{ XE_RTP_RULES(FUNC(match_no)) },
{ XE_RTP_RULES(FUNC(match_yes)) },
XE_RTP_RULES(FUNC(match_no), OR,
FUNC(match_no), OR,
FUNC(match_yes)) },
{ XE_RTP_NAME("r3"),
XE_RTP_RULES(FUNC(match_no)),
},
Expand All @@ -461,10 +458,9 @@ static const struct rtp_test_case rtp_cases[] = {
XE_RTP_RULES(FUNC(match_no)),
},
{ XE_RTP_NAME("r2_or_conditions"),
XE_RTP_RULES(FUNC(match_no)),
},
{ XE_RTP_RULES(FUNC(match_no)) },
{ XE_RTP_RULES(FUNC(match_no)) },
XE_RTP_RULES(FUNC(match_no), OR,
FUNC(match_no), OR,
FUNC(match_no)) },
{ XE_RTP_NAME("r3"),
XE_RTP_RULES(FUNC(match_no)),
},
Expand Down
16 changes: 12 additions & 4 deletions drivers/gpu/drm/xe/xe_gen_wa_oob.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -97,19 +97,27 @@ static int parse(FILE *input, FILE *csource, FILE *cheader)

if (name) {
fprintf(cheader, "\tXE_WA_OOB_%s = %u,\n", name, idx);
fprintf(csource, "{ XE_RTP_NAME(\"%s\"), XE_RTP_RULES(%s) },\n",

/* Close previous entry before starting a new one */
if (idx)
fprintf(csource, ") },\n");

fprintf(csource, "{ XE_RTP_NAME(\"%s\"),\n XE_RTP_RULES(%s",
name, rules);
idx++;
} else {
fprintf(csource, "{ XE_RTP_NAME(NULL), XE_RTP_RULES(%s) },\n",
rules);
fprintf(csource, ", OR,\n\t%s", rules);
}

idx++;
lineno++;
if (!is_continuation)
prev_name = name;
}

/* Close last entry */
if (idx)
fprintf(csource, ") },\n");

fprintf(cheader, "\t_XE_WA_OOB_COUNT = %u\n", idx);

return 0;
Expand Down
36 changes: 10 additions & 26 deletions drivers/gpu/drm/xe/xe_rtp.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -221,15 +221,15 @@ EXPORT_SYMBOL_IF_KUNIT(xe_rtp_process_ctx_enable_active_tracking);

static void rtp_mark_active(struct xe_device *xe,
struct xe_rtp_process_ctx *ctx,
unsigned int first, unsigned int n_entries)
unsigned int idx)
{
if (!ctx->active_entries)
return;

if (drm_WARN_ON(&xe->drm, first + n_entries > ctx->n_entries))
if (drm_WARN_ON(&xe->drm, idx >= ctx->n_entries))
return;

bitmap_set(ctx->active_entries, first, n_entries);
bitmap_set(ctx->active_entries, idx, 1);
}

/**
Expand Down Expand Up @@ -274,7 +274,7 @@ void xe_rtp_process_to_sr(struct xe_rtp_process_ctx *ctx,
}

if (match)
rtp_mark_active(xe, ctx, entry - entries, 1);
rtp_mark_active(xe, ctx, entry - entries);
}
}
EXPORT_SYMBOL_IF_KUNIT(xe_rtp_process_to_sr);
Expand All @@ -285,42 +285,26 @@ EXPORT_SYMBOL_IF_KUNIT(xe_rtp_process_to_sr);
* @entries: Table with RTP definitions
*
* Walk the table pointed by @entries (with an empty sentinel), executing the
* rules. A few differences from xe_rtp_process_to_sr():
*
* 1. There is no action associated with each entry since this uses
* struct xe_rtp_entry. Its main use is for marking active workarounds via
* xe_rtp_process_ctx_enable_active_tracking().
* 2. There is support for OR operations by having entries with no name.
* rules. One difference from xe_rtp_process_to_sr(): there is no action
* associated with each entry since this uses struct xe_rtp_entry. Its main use
* is for marking active workarounds via
* xe_rtp_process_ctx_enable_active_tracking().
*/
void xe_rtp_process(struct xe_rtp_process_ctx *ctx,
const struct xe_rtp_entry *entries)
{
const struct xe_rtp_entry *entry, *first_entry;
const struct xe_rtp_entry *entry;
struct xe_hw_engine *hwe;
struct xe_gt *gt;
struct xe_device *xe;

rtp_get_context(ctx, &hwe, &gt, &xe);

first_entry = entries;
if (drm_WARN_ON(&xe->drm, !first_entry->name))
return;

for (entry = entries; entry && entry->rules; entry++) {
if (entry->name)
first_entry = entry;

if (!rule_matches(xe, gt, hwe, entry->rules, entry->n_rules))
continue;

/* Fast-forward entry, eliminating the OR'ed entries */
for (entry++; entry && entry->rules; entry++)
if (entry->name)
break;
entry--;

rtp_mark_active(xe, ctx, first_entry - entries,
entry - first_entry + 1);
rtp_mark_active(xe, ctx, entry - entries);
}
}
EXPORT_SYMBOL_IF_KUNIT(xe_rtp_process);
Expand Down

0 comments on commit dbcbfc7

Please sign in to comment.