Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bridge: clean ip masq if netns is empty #811

Closed

Conversation

qkboy
Copy link

@qkboy qkboy commented Jan 18, 2023

In the Del command it didn't clean ip masq when netns is empty. Add the clean-up code if ip address can fetch from prevResult in StdinData.

Fix #810

In the Del command it didn't clean ip masq when netns is empty.
Add the clean-up code if ip address can fetch from prevResult in StdinData.

Fix containernetworking#810

Signed-off-by: hyphen.wang <[email protected]>
@qkboy qkboy force-pushed the bridge-clean-masq-if-netns-empty branch from e7d5b5b to b65130c Compare January 18, 2023 03:48
@github-actions
Copy link

This PR has been untouched for too long without an update. It will be closed in 7 days.

@AkihiroSuda
Copy link
Contributor

@s1061123 @squeed Any chance to consider reopening and merging this PR?

@apostasie
Copy link

@qkboy would you be willing to rebase and carry this through?

@qkboy qkboy closed this Aug 23, 2024
@qkboy qkboy deleted the bridge-clean-masq-if-netns-empty branch August 23, 2024 10:32
@AkihiroSuda
Copy link
Contributor

This seems reopened as:

@qkboy
Copy link
Author

qkboy commented Aug 23, 2024

Sorry, I deleted the original branch by mistake and cannot reopen this pull request. Just recreate a new one. #1078

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bridge plugin leak ip masq if netns is empty
4 participants