Use newer type hint syntax #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly PEP 585 and PEP 604. I keep wanting to do this every time I edit a file, so might as well get it all out of the way before working on other stuff.
Replacing
Optional[x]withx | Noneis a little picky, but all else being equal, I think it's better to have one less import. (Thefrom __future__ import annotationsimports should no longer be necessary whenever pyspacer's minimum version is bumped far enough; I believe it's 3.9 for PEP 585, 3.10 for PEP 604.)