Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update example to latest image #40

Merged
merged 2 commits into from
Jul 30, 2024
Merged

chore: Update example to latest image #40

merged 2 commits into from
Jul 30, 2024

Conversation

NavarrePratt
Copy link
Collaborator

  • Update image used to ghcr.io/coreweave/nccl-tests:12.4.1-cudnn-devel-ubuntu20.04-nccl2.21.5-1-85f9143
  • Remove unneccsary affinities with CKS (region, IB speed)
  • Standardize nccl_test args to -b 512M -e 8G -f 2 -g 1

@NavarrePratt NavarrePratt requested review from salanki and antgun42 July 30, 2024 16:29
@NavarrePratt NavarrePratt self-assigned this Jul 30, 2024
antgun42
antgun42 approved these changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@antgun42 antgun42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the region references in the filenames?

@NavarrePratt NavarrePratt merged commit 3de2b90 into master Jul 30, 2024
@NavarrePratt NavarrePratt deleted the npratt/update-examples branch July 30, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antgun42 antgun42 antgun42 approved these changes

@salanki salanki Awaiting requested review from salanki

Assignees

@NavarrePratt NavarrePratt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NavarrePratt @antgun42