Skip to content

Commit

Permalink
Skip LGTM analysis for the bootstrap library and tools
Browse files Browse the repository at this point in the history
This is because the same code is built for the bootstrap library with
non-standard options like disabled threads, which causes false alerts.
So we build the bootstrap tools in the "configure" step.

Additionally we update the configure flags to only the ones that
matter for the CMake build, after the latest configure script updates.

Change-Id: Id4f90db2a16904f6665f3994f23a9f2a974aefc6
Reviewed-by: Volker Hilsheimer <[email protected]>
  • Loading branch information
jimis committed Jul 15, 2020
1 parent b7ccc80 commit 273be0b
Showing 1 changed file with 14 additions and 4 deletions.
18 changes: 14 additions & 4 deletions .lgtm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,18 @@ extraction:
\ | tar -xzf - --strip-components=1 -C $HOME/cmake-3.17
- export PATH=$HOME/cmake-3.17/bin:$PATH

# Pre-analysis step.
configure:
command: "./configure -cmake -opensource -confirm-license -debug -no-optimize-debug \
\ -nomake tests -nomake examples -no-harfbuzz -no-iconv -system-pcre -system-zlib \
\ -system-freetype -system-libpng -system-libjpeg -system-sqlite -- -DFEATURE_system_sqlite=ON \
\ -DQT_NO_MAKE_TESTS=ON -DQT_NO_MAKE_EXAMPLES=ON"
command:
- "./configure -cmake -opensource -confirm-license -debug -no-pch \
\ -nomake tests -nomake examples -no-harfbuzz \
\ -system-pcre -system-zlib -system-freetype -system-libpng \
\ -system-libjpeg -system-sqlite"
# We skip analyzing the bootstrap library, since the same code is
# built with non-standard flags and false-positives are flagged.
- ninja bootstrap_tools

# Actual analysis.
index:
build_command:
- ninja

0 comments on commit 273be0b

Please sign in to comment.