Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added default topic arn to master config. Added tests to ensure pipeline #241

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

p5k6
Copy link
Contributor

@p5k6 p5k6 commented Apr 27, 2016

defs override default config.

Reference issue #240

One note - the DEFAULT_TOPIC_ARN in dataduct/etl/etl_pipeline.py is defined within the class, rather than outside (as other vars are - such as S3_ETL_BUCKET), because

  • it keeps the global namespace a little cleaner
  • mocking is far easier, as the var is local to the class level at that point

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 64.343% when pulling 8c1584e on p5k6:add_topic_arn_config into 05b81ea on coursera:develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants