-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(atomic): migrate atomic-icon #4998
Open
y-lakhdar
wants to merge
69
commits into
KIT-4022
Choose a base branch
from
KIT-3948
base: KIT-4022
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+304
−124
Open
Changes from 1 commit
Commits
Show all changes
69 commits
Select commit
Hold shift + click to select a range
6d9e506
update getAssetPath
y-lakhdar 653a020
draft
y-lakhdar 3731a81
add binding logic
y-lakhdar 554ab34
update binding controller
y-lakhdar 818d0a3
cleanup
y-lakhdar 354de48
update vitest
y-lakhdar 7452e1d
update vitest
y-lakhdar e3c68f3
revert watch
y-lakhdar 32e9623
mock resourceUrl
y-lakhdar f30ea52
add mock
y-lakhdar 628c157
Update packages/atomic/scripts/build.mjs
y-lakhdar b85f5e1
move mock in setup
y-lakhdar 3eb9857
test atomic icon
y-lakhdar dbc513b
lint
y-lakhdar 24924ca
artifacts
y-lakhdar ac50c2b
Merge branch 'KIT-3944' of github.com:coveo/ui-kit into KIT-3948
y-lakhdar e73ce02
Merge branch 'master' of github.com:coveo/ui-kit into KIT-3944
y-lakhdar d6f69ba
exit on error
y-lakhdar b6238f9
update tsconfig
y-lakhdar f520321
Merge branch 'KIT-3944' of github.com:coveo/ui-kit into KIT-3948
y-lakhdar ec6437a
lock
y-lakhdar ec2522e
build
y-lakhdar 2aaa282
Merge branch 'master' of github.com:coveo/ui-kit into KIT-3944
y-lakhdar e520d8a
Merge branch 'KIT-3944' of github.com:coveo/ui-kit into KIT-3948
y-lakhdar 8b6ec91
Add generated files
033fbb7
update storybook staticDir serving
y-lakhdar 3e6b70e
Merge branch 'master' into KIT-3944
y-lakhdar f0a88df
Merge branch 'master' into KIT-3944
y-lakhdar 69213d7
prettier
y-lakhdar 746b588
Merge branch 'KIT-3944' of github.com:coveo/ui-kit into KIT-3944
y-lakhdar 55c8a37
Merge branch 'master' into KIT-3944
y-lakhdar ff12021
staticDirs for localhost
y-lakhdar c5bb7d7
apply corrections
y-lakhdar 79c649e
Merge branch 'KIT-3944' of github.com:coveo/ui-kit into KIT-3948
y-lakhdar 0789c80
Merge branch 'master' of github.com:coveo/ui-kit into KIT-3948
y-lakhdar 33ba558
fix build error
y-lakhdar 8a7cefb
Merge branch 'master' of github.com:coveo/ui-kit into KIT-3948
y-lakhdar 2e68b36
fix css
y-lakhdar 978d689
clean css
y-lakhdar 1eb2159
Merge branch 'master' of github.com:coveo/ui-kit into KIT-3948
y-lakhdar 1483c78
Merge branch 'KIT-4010' of github.com:coveo/ui-kit into KIT-3948
y-lakhdar 44d80af
remove dep
y-lakhdar 85f5e74
apply pr corrections
y-lakhdar 95d67fd
add mdx
y-lakhdar ac8c322
fix component error
y-lakhdar 15b9379
fix css
y-lakhdar fe18102
Add generated files
5a3a64f
make css global
y-lakhdar 9a02edd
Merge branch 'KIT-3948' of github.com:coveo/ui-kit into KIT-3948
y-lakhdar 674472e
build
y-lakhdar cbfca94
simplify tests
y-lakhdar 296ac85
add into light dom
y-lakhdar 1417d3b
add injectStylesForNoShadowDOM decorator
y-lakhdar 6b7f4a4
update id
y-lakhdar 84cb316
add component error custom element
y-lakhdar be904b4
stories
y-lakhdar dca3d9a
simplify decorator
y-lakhdar 69e4efd
update story
y-lakhdar 0fcfb0e
Add generated files
601b95d
remove unnecessary style attribute
y-lakhdar 4409c0d
Merge branch 'KIT-4022' of github.com:coveo/ui-kit into KIT-3948
y-lakhdar 6543f72
clean merge
y-lakhdar 68a4e61
build
y-lakhdar f89202a
Merge branch 'KIT-4032' into KIT-4022
y-lakhdar 29cf7e6
Merge branch 'KIT-4022' into KIT-3948
y-lakhdar f905d8a
build
y-lakhdar 45a02de
Merge branch 'KIT-4022' into KIT-3948
y-lakhdar 70231bd
Add generated files
e2e4237
Merge branch 'KIT-4022' of github.com:coveo/ui-kit into KIT-3948
y-lakhdar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add generated files
- Loading branch information
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commiting a generated file is quite an anti pattern. Why are we doing it here ?