Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(atomic): migrate atomic-icon #4998

Open
wants to merge 69 commits into
base: KIT-4022
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
69 commits
Select commit Hold shift + click to select a range
6d9e506
update getAssetPath
y-lakhdar Feb 6, 2025
653a020
draft
y-lakhdar Feb 6, 2025
3731a81
add binding logic
y-lakhdar Feb 7, 2025
554ab34
update binding controller
y-lakhdar Feb 10, 2025
818d0a3
cleanup
y-lakhdar Feb 10, 2025
354de48
update vitest
y-lakhdar Feb 11, 2025
7452e1d
update vitest
y-lakhdar Feb 11, 2025
e3c68f3
revert watch
y-lakhdar Feb 11, 2025
32e9623
mock resourceUrl
y-lakhdar Feb 13, 2025
f30ea52
add mock
y-lakhdar Feb 13, 2025
628c157
Update packages/atomic/scripts/build.mjs
y-lakhdar Feb 13, 2025
b85f5e1
move mock in setup
y-lakhdar Feb 14, 2025
3eb9857
test atomic icon
y-lakhdar Feb 18, 2025
dbc513b
lint
y-lakhdar Feb 18, 2025
24924ca
artifacts
y-lakhdar Feb 18, 2025
ac50c2b
Merge branch 'KIT-3944' of github.com:coveo/ui-kit into KIT-3948
y-lakhdar Feb 18, 2025
e73ce02
Merge branch 'master' of github.com:coveo/ui-kit into KIT-3944
y-lakhdar Feb 19, 2025
d6f69ba
exit on error
y-lakhdar Feb 19, 2025
b6238f9
update tsconfig
y-lakhdar Feb 19, 2025
f520321
Merge branch 'KIT-3944' of github.com:coveo/ui-kit into KIT-3948
y-lakhdar Feb 19, 2025
ec6437a
lock
y-lakhdar Feb 19, 2025
ec2522e
build
y-lakhdar Feb 19, 2025
2aaa282
Merge branch 'master' of github.com:coveo/ui-kit into KIT-3944
y-lakhdar Feb 20, 2025
e520d8a
Merge branch 'KIT-3944' of github.com:coveo/ui-kit into KIT-3948
y-lakhdar Feb 20, 2025
8b6ec91
Add generated files
Feb 20, 2025
033fbb7
update storybook staticDir serving
y-lakhdar Feb 20, 2025
3e6b70e
Merge branch 'master' into KIT-3944
y-lakhdar Feb 21, 2025
f0a88df
Merge branch 'master' into KIT-3944
y-lakhdar Feb 21, 2025
69213d7
prettier
y-lakhdar Feb 21, 2025
746b588
Merge branch 'KIT-3944' of github.com:coveo/ui-kit into KIT-3944
y-lakhdar Feb 21, 2025
55c8a37
Merge branch 'master' into KIT-3944
y-lakhdar Feb 24, 2025
ff12021
staticDirs for localhost
y-lakhdar Feb 24, 2025
c5bb7d7
apply corrections
y-lakhdar Feb 24, 2025
79c649e
Merge branch 'KIT-3944' of github.com:coveo/ui-kit into KIT-3948
y-lakhdar Feb 24, 2025
0789c80
Merge branch 'master' of github.com:coveo/ui-kit into KIT-3948
y-lakhdar Feb 24, 2025
33ba558
fix build error
y-lakhdar Feb 25, 2025
8a7cefb
Merge branch 'master' of github.com:coveo/ui-kit into KIT-3948
y-lakhdar Feb 25, 2025
2e68b36
fix css
y-lakhdar Feb 25, 2025
978d689
clean css
y-lakhdar Feb 25, 2025
1eb2159
Merge branch 'master' of github.com:coveo/ui-kit into KIT-3948
y-lakhdar Feb 28, 2025
1483c78
Merge branch 'KIT-4010' of github.com:coveo/ui-kit into KIT-3948
y-lakhdar Feb 28, 2025
44d80af
remove dep
y-lakhdar Feb 28, 2025
85f5e74
apply pr corrections
y-lakhdar Feb 28, 2025
95d67fd
add mdx
y-lakhdar Feb 28, 2025
ac8c322
fix component error
y-lakhdar Mar 3, 2025
15b9379
fix css
y-lakhdar Mar 3, 2025
fe18102
Add generated files
Mar 3, 2025
5a3a64f
make css global
y-lakhdar Mar 3, 2025
9a02edd
Merge branch 'KIT-3948' of github.com:coveo/ui-kit into KIT-3948
y-lakhdar Mar 3, 2025
674472e
build
y-lakhdar Mar 3, 2025
cbfca94
simplify tests
y-lakhdar Mar 4, 2025
296ac85
add into light dom
y-lakhdar Mar 5, 2025
1417d3b
add injectStylesForNoShadowDOM decorator
y-lakhdar Mar 5, 2025
6b7f4a4
update id
y-lakhdar Mar 5, 2025
84cb316
add component error custom element
y-lakhdar Mar 5, 2025
be904b4
stories
y-lakhdar Mar 5, 2025
dca3d9a
simplify decorator
y-lakhdar Mar 5, 2025
69e4efd
update story
y-lakhdar Mar 6, 2025
0fcfb0e
Add generated files
Mar 6, 2025
601b95d
remove unnecessary style attribute
y-lakhdar Mar 6, 2025
4409c0d
Merge branch 'KIT-4022' of github.com:coveo/ui-kit into KIT-3948
y-lakhdar Mar 6, 2025
6543f72
clean merge
y-lakhdar Mar 6, 2025
68a4e61
build
y-lakhdar Mar 6, 2025
f89202a
Merge branch 'KIT-4032' into KIT-4022
y-lakhdar Mar 6, 2025
29cf7e6
Merge branch 'KIT-4022' into KIT-3948
y-lakhdar Mar 6, 2025
f905d8a
build
y-lakhdar Mar 6, 2025
45a02de
Merge branch 'KIT-4022' into KIT-3948
y-lakhdar Mar 6, 2025
70231bd
Add generated files
Mar 6, 2025
e2e4237
Merge branch 'KIT-4022' of github.com:coveo/ui-kit into KIT-3948
y-lakhdar Mar 6, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add generated files
  • Loading branch information
GitHub Actions Bot committed Mar 3, 2025
commit fe18102b568f9af98f0cc6b889112de029c033ec
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {APP_INITIALIZER, ModuleWithProviders, NgModule, Provider} from '@angular


import {
AtomicComponentError,
AtomicIcon,
AtomicAriaLive,
AtomicAutomaticFacet,
Expand Down Expand Up @@ -39,7 +40,6 @@ AtomicCommerceSearchBoxRecentQueries,
AtomicCommerceSortDropdown,
AtomicCommerceText,
AtomicCommerceTimeframeFacet,
AtomicComponentError,
AtomicDidYouMean,
AtomicExternal,
AtomicFacet,
Expand Down Expand Up @@ -151,6 +151,7 @@ defineCustomElements(window);


const DECLARATIONS = [
AtomicComponentError,
AtomicIcon,
AtomicAriaLive,
AtomicAutomaticFacet,
Expand Down Expand Up @@ -185,7 +186,6 @@ AtomicCommerceSearchBoxRecentQueries,
AtomicCommerceSortDropdown,
AtomicCommerceText,
AtomicCommerceTimeframeFacet,
AtomicComponentError,
AtomicDidYouMean,
AtomicExternal,
AtomicFacet,
Expand Down
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commiting a generated file is quite an anti pattern. Why are we doing it here ?

Original file line number Diff line number Diff line change
Expand Up @@ -762,28 +762,6 @@ export class AtomicCommerceTimeframeFacet {
export declare interface AtomicCommerceTimeframeFacet extends Components.AtomicCommerceTimeframeFacet {}


@ProxyCmp({
inputs: ['element', 'error']
})
@Component({
selector: 'atomic-component-error',
changeDetection: ChangeDetectionStrategy.OnPush,
template: '<ng-content></ng-content>',
// eslint-disable-next-line @angular-eslint/no-inputs-metadata-property
inputs: ['element', 'error'],
})
export class AtomicComponentError {
protected el: HTMLElement;
constructor(c: ChangeDetectorRef, r: ElementRef, protected z: NgZone) {
c.detach();
this.el = r.nativeElement;
}
}


export declare interface AtomicComponentError extends Components.AtomicComponentError {}


@ProxyCmp({
inputs: ['automaticallyCorrectQuery', 'queryCorrectionMode']
})
Expand Down Expand Up @@ -3085,6 +3063,29 @@ export declare interface AtomicTimeframeFacet extends Components.AtomicTimeframe

//#region Lit Declarations

@ProxyCmp({
inputs: ['element', 'error']
})
@Component({
selector: 'atomic-component-error',
changeDetection: ChangeDetectionStrategy.OnPush,
template: '<ng-content></ng-content>',
// eslint-disable-next-line @angular-eslint/no-inputs-metadata-property
inputs: ['element', 'error']
})
export class AtomicComponentError {
protected readonly el: HTMLElement;
constructor(c: ChangeDetectorRef, el: ElementRef, protected z: NgZone) {
c.detach();
this.el = el.nativeElement;
proxyOutputs(this, this.el, []);
}
}

export declare interface AtomicComponentError extends LitAtomicComponentError {

}

@ProxyCmp({
inputs: ['icon']
})
Expand All @@ -3108,5 +3109,5 @@ export declare interface AtomicIcon extends LitAtomicIcon {

}

import type {AtomicIcon as LitAtomicIcon} from '@coveo/atomic/components';
import type {AtomicComponentError as LitAtomicComponentError, AtomicIcon as LitAtomicIcon} from '@coveo/atomic/components';
//#endregion Lit Declarations
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ export const AtomicAutomaticFacetGenerator = /*@__PURE__*/createReactComponent<J
export const AtomicBreadbox = /*@__PURE__*/createReactComponent<JSX.AtomicBreadbox, HTMLAtomicBreadboxElement>('atomic-breadbox');
export const AtomicCategoryFacet = /*@__PURE__*/createReactComponent<JSX.AtomicCategoryFacet, HTMLAtomicCategoryFacetElement>('atomic-category-facet');
export const AtomicColorFacet = /*@__PURE__*/createReactComponent<JSX.AtomicColorFacet, HTMLAtomicColorFacetElement>('atomic-color-facet');
export const AtomicComponentError = /*@__PURE__*/createReactComponent<JSX.AtomicComponentError, HTMLAtomicComponentErrorElement>('atomic-component-error');
export const AtomicDidYouMean = /*@__PURE__*/createReactComponent<JSX.AtomicDidYouMean, HTMLAtomicDidYouMeanElement>('atomic-did-you-mean');
export const AtomicExternal = /*@__PURE__*/createReactComponent<JSX.AtomicExternal, HTMLAtomicExternalElement>('atomic-external');
export const AtomicFacet = /*@__PURE__*/createReactComponent<JSX.AtomicFacet, HTMLAtomicFacetElement>('atomic-facet');
Expand Down