Features/support structured append #98
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
I just noticed this after I implemented it from scratch myself in #132. Sorry @vertical-axis! It seems like the core of our patches are identical, but I'm going to leave mine open becaue it seems like yours has fallen behind the master branch. We could merge our tests together: you wrote a unit test, I wrote an end-to-end test that uses structured append to reassemble fragments. I think they're both helpful :) |
danimoh
added a commit
to danimoh/jsQR
that referenced
this pull request
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear @cozmo
jsQR has not supported "Structured Append QR Code" yet.
I implemented code about it.
Could you check my code and accept my pull request?