[intro.defs], [dcl.attr.deprecated], [cpp.error] Define the term "warning" and use where appropriate #7893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eisenwave
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7730.
Closes #7728.
The standard currently uses the term "warning" and "diagnostic message", but only the latter term is defined. It would be possible to purge "warning", but @jwakely suggested instead to keep both terms to retain the standard's expressiveness.
I agree with this direction, and the fix is simple.
The overwhelming majority of diagnostic messages are part of IF or IFNDR behavior, or part of an assertion or erroneous behavior, etc.. Only [cpp.error] (
#warning) and [dcl.attr.deprecated] ([[deprecated]]) say "diagnostic message" when they could clearly say "warning".