This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added in an option in config.json for doing manual auto completion, and a keybinding for it.
It was difficult to find a good place to hook up the keybinding to the action. First I tried to get it in the ClangViewAutocomplete constructor, but accelerators are global and I couldn't get them to act on the currently active view. It might be possible, but I don't know GTK well enough.
Second attempt was in the Notebook constructor, but that is called before the config is loaded, so that didn't work either.
In the end, I just put it in juci.cc, in the on_activate function. This is probably not where it should be, but it works now. Any ideas where it might be better suited? Or is there a better way to hook up keybindings all together?
Also, I'm not sure what happened to the submodules.. I think they just got updated. I haven't edited anything in them atleast.