Skip to content

Commit

Permalink
less type covert call (pingcap#7102)
Browse files Browse the repository at this point in the history
  • Loading branch information
ngaut authored Jul 19, 2018
1 parent 6663f63 commit eeb08a9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion expression/aggregation/concat.go
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ func (cf *concatFunction) Update(evalCtx *AggEvaluateContext, sc *stmtctx.Statem
if err != nil {
return errors.Trace(err)
}
if value.GetValue() == nil {
if value.IsNull() {
return nil
}
datumBuf = append(datumBuf, value)
Expand Down
2 changes: 1 addition & 1 deletion expression/aggregation/count.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ func (cf *countFunction) Update(evalCtx *AggEvaluateContext, sc *stmtctx.Stateme
if err != nil {
return errors.Trace(err)
}
if value.GetValue() == nil {
if value.IsNull() {
return nil
}
if cf.Mode == FinalMode || cf.Mode == Partial2Mode {
Expand Down

0 comments on commit eeb08a9

Please sign in to comment.