Skip to content

Commit

Permalink
Minor improvements
Browse files Browse the repository at this point in the history
* Ignore .vscode and logs folders
* Remove accidentally added log
* Always use a named logger
* Update charTyped argument names
* Remove unused MixinEntryListWidgetEntries
* Add mixins.json minVersion
* Update mixins.json compatibilityLevel
  • Loading branch information
jackassmc committed Aug 29, 2021
1 parent 898dd72 commit 7dfac9a
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 28 deletions.
6 changes: 5 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,17 @@ out
*.iml
.idea

# vscode
.vscode

# gradle
build
.gradle

# other
eclipse
run
logs

Thumbs.db
*.psd
*.psd
Empty file removed logs/latest.log
Empty file.
2 changes: 1 addition & 1 deletion src/main/java/com/terraformersmc/modmenu/ModMenu.java
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@

public class ModMenu implements ClientModInitializer {
public static final String MOD_ID = "modmenu";
public static final Logger LOGGER = LogManager.getLogger();
public static final Logger LOGGER = LogManager.getLogger("Mod Menu");
public static final Gson GSON = new GsonBuilder().setFieldNamingPolicy(FieldNamingPolicy.LOWER_CASE_WITH_UNDERSCORES).setPrettyPrinting().create();

public static final Map<String, Mod> MODS = new HashMap<>();
Expand Down
6 changes: 3 additions & 3 deletions src/main/java/com/terraformersmc/modmenu/gui/ModsScreen.java
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public class ModsScreen extends Screen {
private static final TranslatableText TOGGLE_FILTER_OPTIONS = new TranslatableText("modmenu.toggleFilterOptions");
private static final TranslatableText CONFIGURE = new TranslatableText("modmenu.configure");

private static final Logger LOGGER = LogManager.getLogger();
private static final Logger LOGGER = LogManager.getLogger("Mod Menu");

private TextFieldWidget searchBox;
private DescriptionListWidget descriptionListWidget;
Expand Down Expand Up @@ -261,8 +261,8 @@ public boolean keyPressed(int keyCode, int scanCode, int modifiers) {
}

@Override
public boolean charTyped(char char_1, int int_1) {
return this.searchBox.charTyped(char_1, int_1);
public boolean charTyped(char chr, int keyCode) {
return this.searchBox.charTyped(chr, keyCode);
}

@Override
Expand Down

This file was deleted.

4 changes: 2 additions & 2 deletions src/main/resources/mixins.modmenu.json
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{
"required": true,
"minVersion": "0.8",
"package": "com.terraformersmc.modmenu.mixin",
"compatibilityLevel": "JAVA_8",
"compatibilityLevel": "JAVA_16",
"client": [
"MixinEntryListWidgetEntries",
"MixinTitleScreen"
],
"injectors": {
Expand Down

0 comments on commit 7dfac9a

Please sign in to comment.