Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: BUILD_URI includes GitHub run attempt #320

Merged
merged 1 commit into from
Jun 6, 2024
Merged

fix: BUILD_URI includes GitHub run attempt #320

merged 1 commit into from
Jun 6, 2024

Conversation

miki725
Copy link
Contributor

@miki725 miki725 commented Jun 6, 2024

Issue

fixes #319

Description

As you can retry github action run, the link needs to include it, otherwise chalk report always links to the latest run, even if that is not the job attempt which generated the report.

Testing

➜ make tests args="test_plugins.py::test_github"

As you can retry github action run, the link needs to include it,
otherwise chalk report always links to the latest run, even if
that is not the job attempt which generated the report.
@miki725 miki725 marked this pull request as ready for review June 6, 2024 15:03
@miki725 miki725 requested a review from viega as a code owner June 6, 2024 15:03
@ee7 ee7 self-requested a review June 6, 2024 15:54
CHANGELOG.md Show resolved Hide resolved
src/plugins/ciGithub.nim Show resolved Hide resolved
@miki725 miki725 merged commit 12b170b into main Jun 6, 2024
4 checks passed
@miki725 miki725 deleted the ms/attempt branch June 6, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github Actions Include ATTEMPT in BUILD_URI
2 participants