-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate changelog with each release #82
Generate changelog with each release #82
Conversation
…own on each release until now) to separate Markdown file (we may use it later somehow)
1b522f3
to
bfbe717
Compare
…nerator` instead of relying on GitHub's release notes generation functionality, which apparently doesn't render the release notes in a Markdown file
…t also works when build is triggered by a non-tag commit, for instance while testing the workflow in a branch, as is the case while writing this commit
…rrent directory, while the code was actually checked out under the subdirectory `./src`
b86bf30
to
fb556db
Compare
fb556db
to
d71dbae
Compare
…eded to generate changelog from commits between latest and previous tags
…ince the actual cause was found: `actions/checkout` checks out the repo with a depth of 1 (only the most recent commit) by default, so history including previous tags isn't available by default (we fixed that configuration in the previous commit)
…its in changelog, even those that don't have a "type" defined according the Conventional Commits format (feat, feature, fix, bugfix, perf, refactor, test, tests, chore`)
ad67975
to
b1838c4
Compare
…show those on each release
b1838c4
to
ca571ba
Compare
f115293
to
6e065a1
Compare
… by a SemVer-compliant version number, for instance `v1.0.0`) is pushed to the Git repo
Here is the most recent successful release based on this change in my branch, to give you an idea what the release notes will look like. @crazii Before you merge this, there are two things you have to be aware of, once this is merged:
For instance, to make the first release in this new format: git tag -a v1.0.0 -m "Release version 1.0.0"
git push origin v1.0.0 Before tagging and pushing a new release, you can enter Oh, and the release notes (changelog going back to the previous release, plus the user instructions that we were always showing in the release up until now) is now being included in both the ZIP file and in the USB image. (In DOS, you can just do I know this can all still be improved further, but let's do so incrementally in separate PRs. Please let me know if you have any questions! If you agree to these conventions and this workflow, feel free to merge this. Thanks! 🙂 |
I think I can give the conventional commits a try, but I have a few question, What about PR from others? It's might be hard to force a restriction on everyone. |
Hi @crazii, sorry for the late reply! To answer your questions:
Shall I just merge this and then we evaluate it going forward? I intend to improve and fine-tune it further as needed, and we can always revert it if need be. Just be aware of the git tagging that you need to perform whenever you are ready to perform another release. No longer will a release automatically be generated for each push or merge to Let me know if you're okay with merging and trying this out for awhile. Thanks! 🙂 |
the beta4 is planned to be released in a couple of days maybe, I think this PR better merged after beta4 release, leaving beta4 with a manually created changelog, and the auto changelog feature will be merged & tested before next release after beta4. |
It seems you're busy, no worries, |
Hi @crazii. Sorry for the late reply. If you believe that this PR is better merged after the beta4 release, then let's do that. Thanks! 🙂 |
OK, I'll get beta4 done and merge it soon. |
Hi @crazii. Now that you have released beta4, is anything blocking us from merging this? Asking, since you hadn't pressed the merge button yet. I can also do it, but I want to make sure you're okay with it being merged at this point. Thanks. |
Oh, maybe you can also approve the PR? Thanks. |
I forgot merging it after resolving conflicts. |
Thank you @crazii ! Let's see how well it works with the next few releases, and then evaluate. I'm happy to improve and tweak this in another PR if and when needed. 👍 |
@crazii As a reminder: from now on, you need to explicitly The upside of this is that you are in control of when a new release is ready. |
Fixes #73