Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accuracy of OpenAI capabilities supports_vision? and supports_functions? methods #56

Merged
merged 5 commits into from
Mar 23, 2025

Conversation

jaggdl
Copy link
Contributor

@jaggdl jaggdl commented Mar 21, 2025

This is still not perfect since OpenAI has lots of models, but it is much better than what it used to have.

I'm not adding the updated models.json because of the scope of this pull request but I could add it if requested.

…rts_functions?` methods
@crmne crmne added the capabilities Update or modify model capabilities label Mar 21, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@crmne
Copy link
Owner

crmne commented Mar 22, 2025

Thank you for this @jaggdl!

Do you mind running rake models:update to update the models.json?

crmne added 3 commits March 23, 2025 11:39

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…models and

refactor model handling in RubyLLM: delegate class methods, add save_models method, and streamline model loading
@crmne crmne merged commit 8fce3ac into crmne:main Mar 23, 2025
4 checks passed
@jaggdl
Copy link
Contributor Author

jaggdl commented Mar 23, 2025

Awesome, thanks @crmne ! Good to see the new OpenAI models ;)

OriPekelman pushed a commit to OriPekelman/ruby_llm that referenced this pull request Mar 24, 2025
…rts_functions?` methods (crmne#56)

This is still not perfect since OpenAI has lots of models, but it is
much better than what it used to have.

Also fixed a bug where RubyLLM.models.refresh! would return the old list of models, and refactored model handling in RubyLLM: delegate class methods, add save_models method, and streamline model loading

---------

Co-authored-by: Carmine Paolino <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
capabilities Update or modify model capabilities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants