Skip to content

Commit

Permalink
Build promises should not return outputNodeWrapper
Browse files Browse the repository at this point in the history
The outputNodeWrapper is internal. Also, it is at
`builder.outputNodeWrapper`, along with outputPath,
and both do not change per build.

Originally this got changed as it was thought to
be needed for ember-cli broccoli 2 support.

If we expose any node, I think it should be the
heimdall node.
  • Loading branch information
krisselden committed Jul 10, 2018
1 parent dfd95c0 commit d189d24
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
1 change: 0 additions & 1 deletion lib/builder.js
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,6 @@ module.exports = class Builder extends EventEmitter {
})
.then(outputNodeWrapper => {
this.buildHeimdallTree(outputNodeWrapper);
return outputNodeWrapper;
}),
() => {
this._cancelationRequest = null;
Expand Down
6 changes: 1 addition & 5 deletions test/builder_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ const path = require('path');
const tmp = require('tmp');
const promiseFinally = require('promise.prototype.finally');
const broccoli = require('..');
const TransformNode = require('../lib/wrappers/transform-node');
const makePlugins = require('./plugins');
const Builder = broccoli.Builder;
const fixturify = require('fixturify');
Expand Down Expand Up @@ -84,10 +83,7 @@ describe('Builder', function() {
let builder = new Builder(stepA);
let promise = builder.build();

return promise.then(node => {
expect(node).to.be.an.instanceOf(TransformNode);
expect(node.node).to.be.an.instanceOf(plugins.Noop);
});
return promise;
});
});

Expand Down

0 comments on commit d189d24

Please sign in to comment.