Merge pull request quarkusio#44499 from brunobat/test-reliability

Improve test reliability II
cstamas · Nov 14, 2024 · 07041d3 · 07041d3
2 parents 30f25fb + 73b1e5c
commit 07041d3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/...test/java/io/quarkus/opentelemetry/deployment/common/exporter/InMemoryMetricExporter.java b/...test/java/io/quarkus/opentelemetry/deployment/common/exporter/InMemoryMetricExporter.java
@@ -106,11 +106,6 @@ private static boolean isPathFound(String path, Attributes attributes) {
         return value.toString().equals(path);
     }
 
-    public void assertCount(final int count) {
-        Awaitility.await().atMost(5, SECONDS)
-                .untilAsserted(() -> Assertions.assertEquals(count, getFinishedMetricItems().size()));
-    }
-
     public void assertCount(final String name, final String target, final int count) {
         Awaitility.await().atMost(5, SECONDS)
                 .untilAsserted(() -> Assertions.assertEquals(count, getFinishedMetricItems(name, target).size()));

diff --git a/...ment/src/test/java/io/quarkus/opentelemetry/deployment/metrics/HttpServerMetricsTest.java b/...ment/src/test/java/io/quarkus/opentelemetry/deployment/metrics/HttpServerMetricsTest.java
@@ -70,7 +70,10 @@ void collectsHttpRouteFromEndAttributes() {
                 .statusCode(INTERNAL_SERVER_ERROR.getStatusCode());
 
         metricExporter.assertCountPointsAtLeast("http.server.request.duration", null, 2);
-        MetricData metric = metricExporter.getFinishedMetricItems("http.server.request.duration", null).get(0);
+        MetricData metric = metricExporter
+                .getFinishedMetricItems("http.server.request.duration", null).stream()
+                .reduce((first, second) -> second) // get the last received
+                .orElse(null);
 
         assertThat(metric)
                 .hasName("http.server.request.duration")