dep: update dumpling dependency (pingcap#1566)

csuzhangxc · Apr 7, 2021 · ef6138b · ef6138b
1 parent f408cb4
commit ef6138b
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 3 deletions.
diff --git a/dumpling/dumpling.go b/dumpling/dumpling.go
@@ -261,6 +261,10 @@ func (m *Dumpling) constructArgs() (*export.Config, error) {
 	if dumpConfig.Consistency == "none" {
 		dumpConfig.PosAfterConnect = true
 	}
+	// set default Rows
+	if dumpConfig.Rows == export.UnspecifiedSize {
+		dumpConfig.Rows = 200000
+	}
 
 	if !cfg.CaseSensitive {
 		dumpConfig.TableFilter = filter.CaseInsensitive(dumpConfig.TableFilter)

diff --git a/dumpling/dumpling_test.go b/dumpling/dumpling_test.go
@@ -127,4 +127,5 @@ func (d *testDumplingSuite) TestDefaultConfig(c *C) {
 	ctx := context.Background()
 	c.Assert(dumpling.Init(ctx), IsNil)
 	c.Assert(dumpling.dumpConfig.StatementSize, Not(Equals), export.UnspecifiedSize)
+	c.Assert(dumpling.dumpConfig.Rows, Not(Equals), export.UnspecifiedSize)
 }
diff --git a/go.mod b/go.mod
@@ -17,7 +17,7 @@ require (
 	github.com/grpc-ecosystem/grpc-gateway v1.14.3
 	github.com/kami-zh/go-capturer v0.0.0-20171211120116-e492ea43421d
 	github.com/pingcap/check v0.0.0-20200212061837-5e12011dc712
-	github.com/pingcap/dumpling v0.0.0-20210226040140-2e8afecad630
+	github.com/pingcap/dumpling v0.0.0-20210407092432-e1cfe4ce0a53
 	github.com/pingcap/errors v0.11.5-0.20201126102027-b0a155152ca3
 	github.com/pingcap/failpoint v0.0.0-20210316064728-7acb0f0a3dfd
 	github.com/pingcap/log v0.0.0-20201112100606-8f1e84a3abc8

diff --git a/go.sum b/go.sum
@@ -722,8 +722,8 @@ github.com/pingcap/check v0.0.0-20200212061837-5e12011dc712 h1:R8gStypOBmpnHEx1q
 github.com/pingcap/check v0.0.0-20200212061837-5e12011dc712/go.mod h1:PYMCGwN0JHjoqGr3HrZoD+b8Tgx8bKnArhSq8YVzUMc=
 github.com/pingcap/dm v1.1.0-alpha.0.20200521025928-83063141c5fd/go.mod h1:I5AAhwb0JPfLZINukML5VU9rB6mCcVA/Jq5OFFtMuEk=
 github.com/pingcap/dumpling v0.0.0-20200423082233-887d037b5b5c/go.mod h1:VJTcnA0MLL9tzDceTDoRh3k5UnOq9Hk6wh/ATo+B8I8=
-github.com/pingcap/dumpling v0.0.0-20210226040140-2e8afecad630 h1:d53sL21i/6qnVRSfcdoPpV1WJpSoVklCnd843wJKahE=
-github.com/pingcap/dumpling v0.0.0-20210226040140-2e8afecad630/go.mod h1:p4siH/MkS7xQRvtk/2+WwLGFMyFWTWAihheeZuWqTzY=
+github.com/pingcap/dumpling v0.0.0-20210407092432-e1cfe4ce0a53 h1:JDD1QmeG3fvTDfHGyOPs1a/xOTpnIt4yRSDD42mFggU=
+github.com/pingcap/dumpling v0.0.0-20210407092432-e1cfe4ce0a53/go.mod h1:hLEeGzRi96SnfjHcvQrwuLW5gRLM8QEJ00eTEalb0d0=
 github.com/pingcap/errcode v0.0.0-20180921232412-a1a7271709d9/go.mod h1:4b2X8xSqxIroj/IZ9MX/VGZhAwc11wB9wRIzHvz6SeM=
 github.com/pingcap/errcode v0.3.0/go.mod h1:4b2X8xSqxIroj/IZ9MX/VGZhAwc11wB9wRIzHvz6SeM=
 github.com/pingcap/errors v0.11.0/go.mod h1:Oi8TUi2kEtXXLMJk9l1cGmz20kV3TaQ0usTwv5KuLY8=