Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add protoc-gen-dart's parent folder to PATH before run protobuf compiler. #124

Closed
wants to merge 2 commits into from
Closed

Add protoc-gen-dart's parent folder to PATH before run protobuf compiler. #124

wants to merge 2 commits into from

Conversation

bookshiyi
Copy link
Contributor

@temeddix Do you think it is necessary?

@temeddix
Copy link
Member

temeddix commented Aug 28, 2023 •
edited
Loading

Hmm, maybe it's okay to skip this because all CI were passing properly. If protoc was unable to compile .proto files, CI would have been failing for sure, because only .proto files are version-controlled and all generated Dart/Rust message files are not included in Git push.

Actually, we have higher priority goals in 'projects' ;)

@temeddix
Copy link
Member

temeddix commented Aug 30, 2023 •
edited
Loading

It looks like CI was somehow automatically updating PATH for dart pub global activate, unlike local environment. Commit c9766d1 fixed this :)

@temeddix temeddix closed this Aug 30, 2023
@bookshiyi bookshiyi deleted the #123-protoc-gen-dart branch September 7, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bookshiyi @temeddix