Skip to content

Commit

Permalink
t9150-svk-mergetickets.sh: use the $( ... ) construct for command sub…
Browse files Browse the repository at this point in the history
…stitution

The Git CodingGuidelines prefer the $(...) construct for command
substitution instead of using the backquotes `...`.

The backquoted form is the traditional method for command
substitution, and is supported by POSIX.  However, all but the
simplest uses become complicated quickly.  In particular, embedded
command substitutions and/or the use of double quotes require
careful escaping with the backslash character.

The patch was generated by:

for _f in $(find . -name "*.sh")
do
	perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg'  "${_f}"
done

and then carefully proof-read.

Signed-off-by: Elia Pinto <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
  • Loading branch information
devzero2000 authored and gitster committed Jan 12, 2016
1 parent e74ef60 commit 9375dcf
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion t/t9150-svk-mergetickets.sh
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ test_expect_success 'load svk depot' "
uuid=b48289b2-9c08-4d72-af37-0358a40b9c15

test_expect_success 'svk merges were represented coming in' "
[ `git cat-file commit HEAD | grep parent | wc -l` -eq 2 ]
[ $(git cat-file commit HEAD | grep parent | wc -l) -eq 2 ]
"

test_done

0 comments on commit 9375dcf

Please sign in to comment.