Skip to content

Commit

Permalink
Git.pm: add comment pointing to t9000
Browse files Browse the repository at this point in the history
parse_mailboxes should probably eventually be completely equivalent to
Mail::Address, and if this happens we can drop the Mail::Address
dependency. Add a comment in the code reminding the current state of the
code, and point to the corresponding failing test to help future
contributors to get it right.

Signed-off-by: Matthieu Moy <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
  • Loading branch information
moy authored and gitster committed Oct 21, 2016
1 parent 8a420ed commit dcfafc5
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions perl/Git.pm
Original file line number Diff line number Diff line change
Expand Up @@ -870,6 +870,8 @@ Return an array of mailboxes extracted from a string.
=cut

# Very close to Mail::Address's parser, but we still have minor
# differences in some cases (see t9000 for examples).
sub parse_mailboxes {
my $re_comment = qr/\((?:[^)]*)\)/;
my $re_quote = qr/"(?:[^\"\\]|\\.)*"/;
Expand Down

0 comments on commit dcfafc5

Please sign in to comment.