Skip to content

Commit

Permalink
arch/tile: add "nop" after "nap" to help GX idle power draw
Browse files Browse the repository at this point in the history
This avoids the hardware istream prefetcher doing unnecessary work.

Signed-off-by: Chris Metcalf <[email protected]>
  • Loading branch information
cmetcalf-tilera committed Apr 2, 2012
1 parent bfffe79 commit 8c92ba6
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions arch/tile/kernel/entry.S
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ STD_ENTRY(cpu_idle_on_new_stack)
/* Loop forever on a nap during SMP boot. */
STD_ENTRY(smp_nap)
nap
nop /* avoid provoking the icache prefetch with a jump */
j smp_nap /* we are not architecturally guaranteed not to exit nap */
jrp lr /* clue in the backtracer */
STD_ENDPROC(smp_nap)
Expand All @@ -105,5 +106,6 @@ STD_ENTRY(_cpu_idle)
.global _cpu_idle_nap
_cpu_idle_nap:
nap
nop /* avoid provoking the icache prefetch with a jump */
jrp lr
STD_ENDPROC(_cpu_idle)
2 changes: 1 addition & 1 deletion arch/tile/kernel/smp.c
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ static void smp_stop_cpu_interrupt(void)
set_cpu_online(smp_processor_id(), 0);
arch_local_irq_disable_all();
for (;;)
asm("nap");
asm("nap; nop");
}

/* This function calls the 'stop' function on all other CPUs in the system. */
Expand Down

0 comments on commit 8c92ba6

Please sign in to comment.