Skip to content

Commit

Permalink
Set -Wframe-larger-than=25344 for a typical cmake clang compile.
Browse files Browse the repository at this point in the history
This ensures that in the "usual" development process building and
running the tests will enforce this stack limit, which is encountered
in google3. This will prevent future development from adding code
and tests which blow over this limit and break google3

Change-Id: If722c7029cca63eb7d1e80de4b640b84839bb020
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/66867
Reviewed-by: David Benjamin <[email protected]>
Commit-Queue: David Benjamin <[email protected]>
Auto-Submit: Bob Beck <[email protected]>
  • Loading branch information
Bob Beck authored and Boringssl LUCI CQ committed Mar 11, 2024
1 parent 29bb1a7 commit ddb002f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ if(CMAKE_COMPILER_IS_GNUCXX OR CLANG)
endif()

if(CLANG)
set(C_CXX_FLAGS "${C_CXX_FLAGS} -Wnewline-eof -fcolor-diagnostics")
set(C_CXX_FLAGS "${C_CXX_FLAGS} -Wnewline-eof -fcolor-diagnostics -Wframe-larger-than=25344")
else()
# GCC (at least 4.8.4) has a bug where it'll find unreachable free() calls
# and declare that the code is trying to free a stack pointer.
Expand Down

0 comments on commit ddb002f

Please sign in to comment.