rgwlc: lock_lambda overwrites ret val

`lock_lambda` captures `ret` by reference, it will overwrites returned value of `bucket_lc_process` when `wait_backoff` is called. Fixes: c069eb7. Signed-off-by: Tongliang Deng <[email protected]>
cybozu · Nov 20, 2023 · c094f1a · c094f1a
1 parent 06b3d30
commit c094f1a
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/rgw/rgw_lc.cc b/src/rgw/rgw_lc.cc
@@ -2133,14 +2133,14 @@ int RGWLC::process(int index, int max_lock_secs, LCWorker* worker,
 
   utime_t lock_for_s(max_lock_secs, 0);
   const auto& lock_lambda = [&]() {
-    ret = lock->try_lock(this, lock_for_s, null_yield);
+    int ret = lock->try_lock(this, lock_for_s, null_yield);
     if (ret == 0) {
       return true;
     }
     if (ret == -EBUSY || ret == -EEXIST) {
       /* already locked by another lc processor */
       return false;
-      }
+    }
     return false;
   };