To add reconciliation time stamps

[Abiji-2020]

📑 Description

Updated the setStatus function in the ModuleReconciler to include the FinishedAt timestamp in the reconciliation status. The FinishedAt field now uses the current time, formatted as a string in RFC3339 format. Updated the custom JSON marshaler and unmarshaler for ReconciliationStatus to handle this timestamp field correctly. Fixes #430

• Added FinishedAt field of type string to ReconciliationStatus.
• Updated setStatus function to set FinishedAt to the current time in RFC3339 format.
• Implemented custom JSON marshaler and unmarshaler for converting FinishedAt between time.Time and string.

✅ Checks

• I have tested my code:
• I have performed a self-review of my code:
  • Ensured setStatus function updates the FinishedAt timestamp correctly.
  • Verified that the custom JSON marshaler and unmarshaler handle the FinishedAt field as expected.

ℹ Additional context

• Related Code Changes:
  • Updated the ReconciliationStatus struct to include a FinishedAt field.
  • Modified the setStatus function in the ModuleReconciler to set the FinishedAt field to the current time.
  • Implemented JSON marshaler and unmarshaler for proper handling of the FinishedAt timestamp.

[petar-cvit]

@Abiji-2020 check the CI. Its failing on unused import

[Abiji-2020]

Updates

There is a time package which was planned to use initally and then i have'nt used it so now i had removed it.

[Abiji-2020]

How can i check for this checking as again tests in CI is failing?

[petar-cvit]

@Abiji-2020 thanks for the PR and the description of your changes! Left two comments, but could you also format the code? I see a lot of changes coming from different indentation

[Abiji-2020]

The code was updated and the formatting was cleared

[petar-cvit]

@Abiji-2020 thanks, looks good! 🧡

Will merge after #582

[petar-cvit]

Hey @Abiji-2020, I tried running Cyclops from your branch one more time and found that Modules kept reconciling endlessly. The issue is that on each reconciliation, finishedAt is updated with a different timestamp, which then triggers a new reconciliation.

We need to change our reconciliation policy in order to include this PR and not trigger unnecessary reconciliations

[Abiji-2020]

Hey @Abiji-2020, I tried running Cyclops from your branch one more time and found that Modules kept reconciling endlessly. The issue is that on each reconciliation, finishedAt is updated with a different timestamp, which then triggers a new reconciliation.

We need to change our reconciliation policy in order to include this PR and not trigger unnecessary reconciliations

so What can we do now. Like modifications.?

[petar-cvit]

@Abiji-2020 yeah, I will make a PR that will introduce event filter so reconciliation is not triggered on every module update. Will update here when that PR is merged and merge yours as well :)

[Abiji-2020]

@petar-cvit any updates on this?