This repository has been archived by the owner on Jan 31, 2023. It is now read-only.
feat: allow user to pass sync and async function returning boolean flag #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Seems like it should work, merging. Thank you very much for the pull request |
|
Seems like this feature was not released due to failed circleCi job. Could you re-run it? @bahmutov |
|
I will leave this to the Cypress team
…Sent from my iPhone
On Sep 21, 2021, at 06:39, JenyaJilenko ***@***.***> wrote:
Seems like this feature was not released due to failed circleCi job. Could you re-run it? @bahmutov
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
I might do it if you want, seems like I just messed up when copying code from skipOn to onlyOn and I copied at a wrong place :) Should I create new PR? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should solve #161.
Passing function which returns true or async function returning true to onlyOn and to skipOn.