Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix angry module LSP diagnostic #6086

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

keyboardDrummer
Copy link
Member

What was changed?

Improve LSP diagnostics, so instead of
image
the IDE shows
image

For the errors:
not resolving module '_module' because there were errors in resolving its nested module 'A'"
boolean literal used as if it had type int"

How has this been tested?

  • Added an LSP test

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

Copy link
Member

@MikaelMayer MikaelMayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pfooo thanks for spotting and fixing that, and also putting a test so that it won't happen again !

@MikaelMayer MikaelMayer enabled auto-merge (squash) January 30, 2025 16:39
@MikaelMayer MikaelMayer merged commit 5cd765a into dafny-lang:master Jan 30, 2025
22 checks passed
@keyboardDrummer keyboardDrummer deleted the fixAngryModule branch January 30, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants