Update scenario: Allies and Enemies #2283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Divide settings into three categories: Murphy, Missions and Enemies. Switch to using place stations utility. Put some of the initialization processes into the `setGlobals()`, `constructEnvironment()`, and `mainGMButtons()` functions. Switch to a unified player ship names list and a player ship stats list. Better abstraction of get coolant processing. Get rid of underscore indexed loops. Better processing of Arlenian station where the admiral is convalescing. Remove timed mission options. Update goods processing. Make numbers integers for presentation in comms. Remove reference to unused and undefined table. Fix function name reference to commsShip instead of commsStation. Clearer handling of nebulae impacting player ship coolant. Add instant mission end if station with admiral is destroyed instead of waiting for admiral death countdown expiration. Add goods to Cloud City. Clean up end game statistics including checking numbers before adding to stats screen. Switch from double dot concatenation to string.format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses issues in #2255 - specifically items a through h.
Divide settings into three categories: Murphy, Missions and Enemies.
Switch to using place stations utility.
Put some of the initialization processes into the
setGlobals(),constructEnvironment(), andmainGMButtons()functions.Switch to a unified player ship names list and a player ship stats list.
Better abstraction of get coolant processing.
Get rid of underscore indexed loops.
Better processing of Arlenian station where the admiral is convalescing.
Remove timed mission options.
Update goods processing.
Make numbers integers for presentation in comms.
Remove reference to unused and undefined table.
Fix function name reference to commsShip instead of commsStation.
Clearer handling of nebulae impacting player ship coolant.
Add instant mission end if station with admiral is destroyed instead of waiting for admiral death countdown expiration. Add goods to Cloud City.
Clean up end game statistics including checking numbers before adding to stats screen.
Switch from double dot concatenation to string.format.