forked from kubermatic/kubeone
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add support for OpenStack application credentials and update validati…
…on (kubermatic#1666) * Add variables for application credentials and validate them Signed-off-by: Marvin Beckers <[email protected]> * Remove MachineControllerName field Co-authored-by: Marko Mudrinić <[email protected]> * Handle both 'partial credentials' situations and add test cases Signed-off-by: Marvin Beckers <[email protected]> * Make the linter happy Signed-off-by: Marvin Beckers <[email protected]> * Further disagreements with the linter Signed-off-by: Marvin Beckers <[email protected]> Co-authored-by: Marko Mudrinić <[email protected]>
- Loading branch information
Showing
3 changed files
with
233 additions
and
27 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,157 @@ | ||
| /* | ||
| Copyright 2021 The KubeOne Authors. | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package credentials | ||
|
|
||
| import ( | ||
| "errors" | ||
| "testing" | ||
| ) | ||
|
|
||
| func TestOpenstackValidationFunc(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| tests := []struct { | ||
| name string | ||
| creds map[string]string | ||
| err error | ||
| }{ | ||
| { | ||
| name: "no-credentials", | ||
| creds: map[string]string{}, | ||
| err: errors.New("key OS_AUTH_URL is required but is not present"), | ||
| }, | ||
| { | ||
| name: "application-credentials", | ||
| creds: map[string]string{ | ||
| "OS_TENANT_NAME": "test", | ||
| "OS_AUTH_URL": "https://localhost:5000", | ||
| "OS_DOMAIN_NAME": "test", | ||
| "OS_REGION_NAME": "de", | ||
| "OS_APPLICATION_CREDENTIAL_ID": "1234", | ||
| "OS_APPLICATION_CREDENTIAL_SECRET": "5678", | ||
| }, | ||
| err: nil, | ||
| }, | ||
| { | ||
| name: "no-credential-secret", | ||
| creds: map[string]string{ | ||
| "OS_TENANT_NAME": "test", | ||
| "OS_AUTH_URL": "https://localhost:5000", | ||
| "OS_DOMAIN_NAME": "test", | ||
| "OS_REGION_NAME": "de", | ||
| "OS_APPLICATION_CREDENTIAL_ID": "1234", | ||
| }, | ||
| err: errors.New("only one of OS_APPLICATION_CREDENTIAL_ID, OS_APPLICATION_CREDENTIAL_SECRET is set for application credentials"), | ||
| }, | ||
| { | ||
| name: "no-credential-id", | ||
| creds: map[string]string{ | ||
| "OS_TENANT_NAME": "test", | ||
| "OS_AUTH_URL": "https://localhost:5000", | ||
| "OS_DOMAIN_NAME": "test", | ||
| "OS_REGION_NAME": "de", | ||
| "OS_APPLICATION_CREDENTIAL_SECRET": "5678", | ||
| }, | ||
| err: errors.New("only one of OS_APPLICATION_CREDENTIAL_ID, OS_APPLICATION_CREDENTIAL_SECRET is set for application credentials"), | ||
| }, | ||
| { | ||
| name: "user-credentials", | ||
| creds: map[string]string{ | ||
| "OS_TENANT_NAME": "test", | ||
| "OS_AUTH_URL": "https://localhost:5000", | ||
| "OS_DOMAIN_NAME": "test", | ||
| "OS_REGION_NAME": "de", | ||
| "OS_USERNAME": "1234", | ||
| "OS_PASSWORD": "5678", | ||
| }, | ||
| err: nil, | ||
| }, | ||
| { | ||
| name: "no-password", | ||
| creds: map[string]string{ | ||
| "OS_TENANT_NAME": "test", | ||
| "OS_AUTH_URL": "https://localhost:5000", | ||
| "OS_DOMAIN_NAME": "test", | ||
| "OS_REGION_NAME": "de", | ||
| "OS_USERNAME": "1234", | ||
| }, | ||
| err: errors.New("only one of OS_USERNAME, OS_PASSWORD is set for user credentials"), | ||
| }, | ||
| { | ||
| name: "no-username", | ||
| creds: map[string]string{ | ||
| "OS_TENANT_NAME": "test", | ||
| "OS_AUTH_URL": "https://localhost:5000", | ||
| "OS_DOMAIN_NAME": "test", | ||
| "OS_REGION_NAME": "de", | ||
| "OS_PASSWORD": "5678", | ||
| }, | ||
| err: errors.New("only one of OS_USERNAME, OS_PASSWORD is set for user credentials"), | ||
| }, | ||
| { | ||
| name: "mixed-credentials-1", | ||
| creds: map[string]string{ | ||
| "OS_TENANT_NAME": "test", | ||
| "OS_AUTH_URL": "https://localhost:5000", | ||
| "OS_DOMAIN_NAME": "test", | ||
| "OS_REGION_NAME": "de", | ||
| "OS_APPLICATION_CREDENTIAL_ID": "1234", | ||
| "OS_PASSWORD": "5678", | ||
| }, | ||
| err: errors.New("both app credentials (OS_APPLICATION_CREDENTIAL_ID OS_APPLICATION_CREDENTIAL_SECRET) and user credentials (OS_USERNAME OS_PASSWORD) found"), | ||
| }, | ||
| { | ||
| name: "mixed-credentials-2", | ||
| creds: map[string]string{ | ||
| "OS_TENANT_NAME": "test", | ||
| "OS_AUTH_URL": "https://localhost:5000", | ||
| "OS_DOMAIN_NAME": "test", | ||
| "OS_REGION_NAME": "de", | ||
| "OS_APPLICATION_CREDENTIAL_SECRET": "5678", | ||
| "OS_USERNAME": "1234", | ||
| }, | ||
| err: errors.New("both app credentials (OS_APPLICATION_CREDENTIAL_ID OS_APPLICATION_CREDENTIAL_SECRET) and user credentials (OS_USERNAME OS_PASSWORD) found"), | ||
| }, | ||
| { | ||
| name: "mixed-credentials-3", | ||
| creds: map[string]string{ | ||
| "OS_TENANT_NAME": "test", | ||
| "OS_AUTH_URL": "https://localhost:5000", | ||
| "OS_DOMAIN_NAME": "test", | ||
| "OS_REGION_NAME": "de", | ||
| "OS_APPLICATION_CREDENTIAL_ID": "1234", | ||
| "OS_APPLICATION_CREDENTIAL_SECRET": "5678", | ||
| "OS_USERNAME": "1234", | ||
| "OS_PASSWORD": "5678", | ||
| }, | ||
| err: errors.New("both app credentials (OS_APPLICATION_CREDENTIAL_ID OS_APPLICATION_CREDENTIAL_SECRET) and user credentials (OS_USERNAME OS_PASSWORD) found"), | ||
| }, | ||
| } | ||
|
|
||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| err := openstackValidationFunc(tt.creds) | ||
| if tt.err != nil && err != nil { | ||
| if err.Error() != tt.err.Error() { | ||
| t.Errorf("expected error = '%v', got error = '%v'", tt.err.Error(), err.Error()) | ||
| } | ||
| } else if err != tt.err { | ||
| t.Errorf("%s: expected error = %v, got error = %v", tt.name, tt.err, err) | ||
| } | ||
| }) | ||
| } | ||
| } |