Improvement/tesla-expansion #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix BrickModelTMax mistake.
Uncomment false error log SW messages
Add Button for Refresh and Export to .txt, not functioning yet
correction
Delete button to exportLog
Organize data displayed
Organize advanced battery information
|
This PR is now ready for others to test out on their packs to confirm data is reading correctly. |
Update double battery
format
More accurate check of reading mux to confirm mux is present.
DBC files did not match up with data received from PCS, adjusted start bit to get data usable.
format changes
delete 0x352 mux 2 as some batteries do not send mux 2
dalathegreat
approved these changes
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Added Tesla BMS_serialNumber to More Battery info to better document what battery is in use.
Add autodetect of 0x352 BMS_energyStatus, some batteries are using mux and others are not. If we can detect the Mux, we can display the correct data in More Battery Info and properly calculate SOH.
Example from @dalathegreat, add "static bool new_352_mux = false;" variable to store. Add "if (mux == 2) { new_352_mux = true; }" to can message to detect mux. Still need to get webserver to display correctly.
Remove Errors from printDebugIfActive; Not affecting operation but may be need to send frames to satisfy BMS.
BMS_a022_SW_Over_Current
BMS_a050_SW_Brick_Voltage_MIA
BMS_a090_SW_Gateway_MIA
BMS_a091_SW_ChargePort_MIA
BMS_a092_SW_ChargePort_Mia_On_Hv
BMS_a094_SW_Drive_Inverter_MIA
Correct data BrickModelTMax.
Uncomment multiple lines in More Battery Info data that is not adding useful information and causing confusion.
Organize data for easy reading.
Fix Bug Issue #775 for double battery compile errors.
Add 0x2A4 PCS_thermalStatus to webserver advanced battery for viewing, Issue #661 is requesting event alerts from this data.
Updated 0x2A4 PCS_thermalStatus DBC start bit to read data correctly.
Why
Why does it do it?
How
How does it do it?