Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Analysis Support #71

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

aviralpandey
Copy link
Collaborator

Updates HDL21 to export custom_analysis and raw strings with analyses.

@dan-fritchman
Copy link
Owner

This requires Vlsir/Vlsir#33, correct?

@aviralpandey
Copy link
Collaborator Author

Yes, that's why the tests are failing right now

@dan-fritchman
Copy link
Owner

So given most of the simulator-stuff is dependent on Vlsir/Vlsir#33, which (as of this writing) remains a draft - you wanna spin off the primitives / MosParams stuff separately?

@aviralpandey
Copy link
Collaborator Author

The name raw isn't great, a better name would be something like suffix or raw_suffix to be more descriptive of the it's function.

@aviralpandey
Copy link
Collaborator Author

Type when setting to proto should check whether the input is None. In to_proto optional[str] should be converted to str.

@dan-fritchman dan-fritchman mentioned this pull request Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants