Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impove inputs graph object. #522

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SebastienLagrange
Copy link

@SebastienLagrange SebastienLagrange commented Feb 24, 2020

Impove inputs graph object.
During BuildObjectInputAction for inputs graph object, we manage to convert the JObject into the step property type.
Currently the implementation suppose that the step property type is assignable with a JObject, so directly a JObject or at least something like a IDictionary<string,object>.
I would like that the step property can be of any custom type, some model object of my project.
I think this should be the expected behavior no ?
For that I manage to convert the JObject into an object corresponding the step property type.
I manage both cases :

  1. when the step property is null: so convert the JObject to step property type
  2. or if the step property is not null. For example the step property could be instanciated in the step ctor to inject some dependency. This is what I need actually for my project. In that case I keep the existing step property instance and simply populate this object from the JObject.

…onvert the JObject into the step property type.

We manage both cases when the step property is null (so convert the JObject to step property type) or if the step property is not null. For examlpe the step property could be instanciated in the step ctor to inject some dependency. In that case we will keep the existing step property instance and simply populate this object from the JObject.
@SebastienLagrange SebastienLagrange changed the title During BuildObjectInputAction for inputs graph object, we manage to c… Impove inputs graph object. Feb 24, 2020
@danielgerlag
Copy link
Owner

Could you provide an example of what this enables?

@MohamedElbasuony1
Copy link

MohamedElbasuony1 commented Jun 1, 2021

Any updates @danielgerlag !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants