Fix no method error in systemd service (bensheldon#1173)

* Fix a no method error in systemd service The ActiveSupport::Notifications instrument was called with a nil as an error object and it was throwing a no method error up in the chain. This is due to a missed return check. * Update lib/good_job/systemd_service.rb --------- Co-authored-by: Ben Sheldon [he/him] <[email protected]>
danielrorspace · Dec 11, 2023 · 381228b · 381228b
1 parent 5e9fe23
commit 381228b
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/lib/good_job/systemd_service.rb b/lib/good_job/systemd_service.rb
@@ -11,10 +11,10 @@ module GoodJob # :nodoc:
   #
   class SystemdService
     def self.task_observer(_time, _output, thread_error) # :nodoc:
-      return if thread_error.is_a? Concurrent::CancelledOperationError
+      return if !thread_error || thread_error.is_a?(Concurrent::CancelledOperationError)
 
       ActiveSupport::Notifications.instrument("systemd_watchdog_error.good_job", { error: thread_error })
-      GoodJob._on_thread_error(thread_error) if thread_error
+      GoodJob._on_thread_error(thread_error)
     end
 
     # Indicates whether the service is actively notifying systemd's watchdog.