Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google search page contents #2419

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

cpbotha
Copy link

@cpbotha cpbotha commented Apr 15, 2024

Pull Request Template

⚠️ Before Submitting a PR, read the Contributing Docs in full!

Summary

Use Mozilla's readability.js to pack the text contents of Google Search results into the tool output, so that the LLM has more to work with than just the titles and snippets (one to two sentence extracts).

See #2420

Change Type

Please delete any irrelevant options.

  • Bug fix

Testing

Please describe your test process and include instructions so that we can reproduce your test. If there are any important variables for your testing configuration, list them here.

Test Configuration:

Checklist

Please delete any irrelevant options.

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules.
  • New documents have been locally validated with mkdocs

@cpbotha cpbotha force-pushed the google-search-page-contents branch from 7cdfae0 to dd1bc50 Compare April 21, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant