Add FactoryDescription protocol #33
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Gleb Eliseev <[email protected]> Co-authored-by: Mikhail Kuzmin <[email protected]>
Co-authored-by: Gleb Eliseev <[email protected]> Co-authored-by: Mikhail Kuzmin <[email protected]>
darkleaf
force-pushed
the
inspect-with-meta
branch
from
19017d7 to
93724f2
Compare
darkleaf
reviewed
Nov 9, 2024
darkleaf
reviewed
Nov 9, 2024
darkleaf
reviewed
Nov 9, 2024
darkleaf
reviewed
Nov 9, 2024
Co-authored-by: Gleb Eliseev <[email protected]>
darkleaf
force-pushed
the
inspect-with-meta
branch
from
901d1a9 to
cc7c9d5
Compare
darkleaf
reviewed
Jan 9, 2025
Co-authored-by: Gleb Eliseev <[email protected]>
Co-authored-by: Gleb Eliseev <[email protected]>
Co-authored-by: Gleb Eliseev <[email protected]>
Co-authored-by: Gleb Eliseev <[email protected]>
Co-authored-by: Gleb Eliseev <[email protected]>
darkleaf
reviewed
Jan 9, 2025
Co-authored-by: Bogdan Tiet <[email protected]>
Co-authored-by: Nikita Domnitskii <[email protected]>
darkleaf
reviewed
Jan 10, 2025
Co-authored-by: Bogdan Tiet <[email protected]> Co-authored-by: Nikita Domnitskii <[email protected]>
darkleaf
reviewed
Jan 10, 2025
darkleaf
reviewed
Jan 10, 2025
KGOH
reviewed
Jan 10, 2025
Comment on lines
147
to
163
| :dependencies {`a+di-update-key#0-target :optional | ||
| `a+di-update-key#0-f :optional | ||
| `a+di-update-key#0-arg#0 :optional} | ||
| :description {::di/kind :middleware | ||
| :middleware ::di/update-key | ||
| :target `a | ||
| :f str | ||
| :args ["arg"]}} | ||
| {:key `a+di-update-key#0-target | ||
| :description {::di/kind :trivial | ||
| :object :obj}} | ||
| {:key `a+di-update-key#0-f | ||
| :description {::di/kind :trivial | ||
| :object str}} | ||
| {:key `a+di-update-key#0-arg#0 | ||
| :description {::di/kind :trivial | ||
| :object "arg"}}] |
There was a problem hiding this comment.
может как-то тут связи прописать, порядок обосновать 🤷
There was a problem hiding this comment.
::di/update-key-synthetic-kind :target|:f|:arg
darkleaf
reviewed
Jan 10, 2025
darkleaf
reviewed
Jan 15, 2025
Comment on lines
+736
to
+748
| (let [val @variable] | ||
| (reify | ||
| p/Factory | ||
| (dependencies [_] | ||
| (p/dependencies val)) | ||
| (build [_ deps] | ||
| (p/build val deps)) | ||
| (demolish [_ obj] | ||
| (p/demolish val obj)) | ||
| p/FactoryDescription | ||
| (description [_] | ||
| {::kind :variable | ||
| :variable variable})))) |
There was a problem hiding this comment.
тут попал на регрессию, в var может быть reify от фабрики, это тоже нужно было учесть
darkleaf
reviewed
Jan 15, 2025
Comment on lines
+736
to
+748
| (let [val @variable] | ||
| (reify | ||
| p/Factory | ||
| (dependencies [_] | ||
| (p/dependencies val)) | ||
| (build [_ deps] | ||
| (p/build val deps)) | ||
| (demolish [_ obj] | ||
| (p/demolish val obj)) | ||
| p/FactoryDescription | ||
| (description [_] | ||
| {::kind :variable | ||
| :variable variable})))) |
There was a problem hiding this comment.
и вот тут тоже нужно если описание нет, то писать описание, а так можно же в reify внутри var положить с реализацией, и он вызываться не будет
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #28