-
Notifications
You must be signed in to change notification settings - Fork 69
[native_assets_cli] Curate public toplevel functions #2249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR HealthBreaking changes ✔️
API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
|
1 similar comment
PR HealthBreaking changes ✔️
API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/// This class currently contains the logic of the protocol which is similar to | ||
/// the protocol extensions: validation rules. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: it's not super clear what "similar" means here? Is this logic that is shared by all/most protocol extensions?
This PR tries the curate the toplevel functions which are in the public API of what will be
package:hooks
,package:code_assets
andpackage:data_assets
.The validate functions for the base protocol are moved into a
ProtocolBase
class. (These need to be public becausepackage:native_assets_builder
uses them. And these need to be inpackage:native_assets_cli
because thetest
methods use them.)The Dart docs can be inspected by
pkgs/native_assets_cli$ dart doc .
.TODOs:
Context: