-
Notifications
You must be signed in to change notification settings - Fork 68
[infra] Split up package:native_assets_cli
#2259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
|
package:native_assets_cli
package:native_assets_cli
package:native_assets_cli
package:native_assets_cli
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
README.md
Outdated
| [native_assets_builder](pkgs/native_assets_builder/) | This package is the backend that invokes build hooks. | [][native_assets_builder_issues] | | | ||
| [native_assets_cli](pkgs/native_assets_cli/) | A library that contains the argument and file formats for implementing a native assets CLI. | [][native_assets_cli_issues] | | | ||
| [hooks_runner](pkgs/hooks_runner/) | This package is the backend that invokes build hooks. | [][hooks_runner_issues] | | | ||
| [hooks](pkgs/hooks/) | A library that contains the argument and file formats for implementing a native assets CLI. | [][hooks_issues] | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should pkg:code_assets and pkg:data_assets be added to this list of packages for completeness?
hook-helper-package's Dart API (such as `package:native_assets_cli`) which | ||
abstracts away from syntactic changes. If you do want to directly interact | ||
with the JSON, you can find the relevant schemas in [hook/](hook/). | ||
* If you are a hook-helper-package author, you should likely be this package's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: there's a verb ("using"?) missing here after "be".
Closes: #999
Splits up
package:native_assets_cli
inpackage:hooks
,package:code_assets
andpackage:data_assets
.Renames
package:native_assets_builder
topackage:hooks_runner
.The dependencies are as follows:
hooks
has dev dependencies oncode_assets
anddata_assets
because all the integration tests use these asset types.hooks_runner
has a dependency oncode_assets
due to the kernel-encodingKernelAssets
which is used to bundle the code-assets asset-mapping in various SDKs.hooks_runner
has a dev dependency ondata_assets
because the integration tests use it.Versions:
Internal package structure:
CI:
Publishing:
Rolling: