Skip to content

[jnigen] Generate Kotlin stdlib classes without providing path #2271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 7, 2025

Conversation

HosseinYousefi
Copy link
Member

Closes #2216.

  • Adds Kotlin stdlib to APISummarizer's dependencies, so we can use its classloader to find Kotlin classes. This makes the user experience of generating Kotlin stdlib classes better.
  • We only supported the exact fully qualified names, now we also support package names, so java.util will generate the entire package (same for Koltin stdlib).
  • Also added versions to the dependencies of jnigen and jni (they were removed when we changed from maven to gradle).

cc @jwill

Copy link

github-actions bot commented May 6, 2025

PR Health

Breaking changes ⚠️
Package Change Current Version New Version Needed Version Looking good?
jni Breaking 0.14.1 0.14.1 0.15.0
Got "0.14.1" expected >= "0.15.0" (breaking changes)
⚠️

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
jni _opaque_pthread_mutex_t
_opaque_pthread_cond_t
_Dart_FinalizableHandle
_ReferenceType

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label May 7, 2025
@HosseinYousefi HosseinYousefi merged commit 442ce18 into main May 7, 2025
27 checks passed
@HosseinYousefi HosseinYousefi deleted the kotlin-stdlib branch May 7, 2025 08:46
@coveralls
Copy link

Coverage Status

coverage: 84.536% (+2.9%) from 81.603%
when pulling 586042a on kotlin-stdlib
into 11966f1 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:jni package:jnigen type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[jnigen] Generate Kotlin core classes without providing path
3 participants