[hooks_runner] No hooks performance trace #2294
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: #2236
When there are no hooks, all packages in the dependencies must be checked for
hook/build.dart
.This check for Flutter's
hello_world
takes 1 ms in isolation:INFO: 2025-05-14 08:30:08.854304: _runPackagesWithHook took 850 us. Checked 8 packages.
Inside Flutter this check (in
dart_build
) happens concurrently with other code, so it shows up as taking longer:Because it takes 1 ms, removing the experimental flag in Flutter should not regress
flutter run
/flutter build
.Alternatives tried but not chosen:
Future.wait
for all exists checks concurrently, but this leads to a slowdown for <20 packages when tested locally.