Skip to content

[native_toolchain_c] [code_assets] [data_assets] Fix dartdoc on pub.dev #2318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025

Conversation

dcharkes
Copy link
Collaborator

@dcharkes dcharkes commented May 21, 2025

pub.dev checks the SDK constraint in the pubspec, not the ones for dependencies.

So, bump the SDK constraint on all dependees of package:hooks.

Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:code_assets 0.19.1 ready to publish code_assets-v0.19.1
package:data_assets 0.19.1 ready to publish data_assets-v0.19.1
package:ffi 2.1.4 already published at pub.dev
package:ffigen 19.0.0 already published at pub.dev
package:hooks 0.19.1 already published at pub.dev
package:hooks_runner 0.20.1 ready to publish hooks_runner-v0.20.1
package:jni 0.14.1 already published at pub.dev
package:jnigen 0.14.2-wip WIP (no publish necessary)
package:native_doc_dartifier 0.0.1-pre already published at pub.dev
package:native_toolchain_c 0.16.2 ready to publish native_toolchain_c-v0.16.2
package:objective_c 8.0.0 already published at pub.dev
package:swift2objc 0.0.1-wip WIP (no publish necessary)
package:swiftgen 0.0.1-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

Copy link

github-actions bot commented May 21, 2025

PR Health

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/native_doc_dartifier/example/native_doc_dartifier_example.dart
pkgs/native_doc_dartifier/lib/native_doc_dartifier.dart
pkgs/native_doc_dartifier/lib/src/native_doc_dartifier_base.dart
pkgs/native_doc_dartifier/test/native_doc_dartifier_test.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@coveralls
Copy link

coveralls commented May 21, 2025

Coverage Status

coverage: 85.285%. remained the same
when pulling 85bf840 on fix-api-docs
into f2cae97 on main.

@dcharkes dcharkes changed the base branch from main to dart-3-8 May 21, 2025 13:31
auto-submit bot pushed a commit that referenced this pull request May 21, 2025
Dart 3.8 is out. Let's bump the formatting.

We need to bump the SDK constraints to 3.9.0 dev for:

* #2318
Base automatically changed from dart-3-8 to main May 21, 2025 13:48
Copy link
Member

@HosseinYousefi HosseinYousefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@dcharkes dcharkes merged commit 71741a4 into main May 21, 2025
30 checks passed
@dcharkes dcharkes deleted the fix-api-docs branch May 21, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants