Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dartfmt and strong mode clean #36

Merged
merged 3 commits into from
May 4, 2016
Merged

dartfmt and strong mode clean #36

merged 3 commits into from
May 4, 2016

Conversation

kevmoo
Copy link
Member

@kevmoo kevmoo commented May 4, 2016

No description provided.

@kevmoo kevmoo assigned pq May 4, 2016
@pq
Copy link
Member

pq commented May 4, 2016

LGTM.

Maybe update the changelog and bump the version too?

@pq pq merged commit ddef048 into master May 4, 2016
@kevmoo kevmoo deleted the tweaks branch May 4, 2016 23:05
@kevmoo
Copy link
Member Author

kevmoo commented May 4, 2016

@pq nothing changed that would actually help any users – better to wait until there is something useful 😄

@pq
Copy link
Member

pq commented May 4, 2016

But don't we want to pull this version into the SDK? (IOW: update DEPS?)

@pq
Copy link
Member

pq commented May 4, 2016

I was thinking a version bump to correspond with a rev tag would be cleanest but maybe you're right and we don't care? Your call!

mosuem pushed a commit to dart-lang/tools that referenced this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants