Add override for _fe_analyzer_shared #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently need the dependency overrides because of the circular dev_dependencies and the major version change. It is still safe to publish since no normal dependencies are overridden. The dependency overrides are causing us to pull in incompatible versions of `analyzer` and `_fe_analyzer_shared` since there was a breaking change in the latter. Pulling it in from the SDK should cause both to be compatible until we can drop the overrides entirely.
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Dec 9, 2024
We currently need the dependency overrides because of the circular dev_dependencies and the major version change. It is still safe to publish since no normal dependencies are overridden. The dependency overrides are causing us to pull in incompatible versions of `analyzer` and `_fe_analyzer_shared` since there was a breaking change in the latter. Pulling it in from the SDK should cause both to be compatible until we can drop the overrides entirely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently need the dependency overrides because of the circular
dev_dependencies and the major version change. It is still safe to
publish since no normal dependencies are overridden.
The dependency overrides are causing us to pull in incompatible versions
of
analyzerand_fe_analyzer_sharedsince there was a breakingchange in the latter. Pulling it in from the SDK should cause both to be
compatible until we can drop the overrides entirely.